Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16827: Add telemetry for copy url. #16915

Merged
merged 2 commits into from
Dec 15, 2020
Merged

For #16827: Add telemetry for copy url. #16915

merged 2 commits into from
Dec 15, 2020

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Dec 8, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare mcarare requested review from a team as code owners December 8, 2020 11:00
@mcarare mcarare marked this pull request as draft December 8, 2020 11:00
@mcarare mcarare force-pushed the 16827 branch 2 times, most recently from f831c79 to a866b1a Compare December 8, 2020 11:15
@mcarare
Copy link
Contributor Author

mcarare commented Dec 8, 2020 •
edited
Loading

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?
How often users use the copy URL option from the pop-up menu.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
Measure whether this feature is used by users and how often.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
This is the only way.

4) Can current instrumentation answer these questions?
No. We need a new specific event for a specific app feature.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Usage of copy URL option Category 2 https://github.com//issues/16827

6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
This collection is documented in the metrics.md document document included in the project - https://github.com/mozilla-mobile/fenix/blob/master/docs/metrics.md

7) How long will this data be collected? Choose one of the following:
Until 2021-05-10.

8) What populations will you measure?
All release channels and locales.

9) If this data collection is default on, what is the opt-out mechanism for users?
Users can opt of of data collection by disabling Usage and technical data from Settings -> Data collection.

10) Please provide a general description of how you will analyze this data.
Glean / Amplitude

11) Where do you intend to share the results of your analysis?
Only on Glean, Amplitude and with mobile teams.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
No.

@mcarare mcarare marked this pull request as ready for review December 8, 2020 11:56
@mcarare mcarare added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Dec 8, 2020
@mcarare mcarare changed the title For #16827: Add documentation for copy url metrics. For #16827: Add telemetry for copy url. Dec 10, 2020
boek
boek approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, Fenix data collection settings.

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    No, Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry

  9. Does the data collection use a third-party collection tool?
    No

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2020

This pull request has conflicts when rebasing. Could you fix it @mcarare? 🙏

@mcarare mcarare added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land and removed needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Dec 15, 2020
@mcarare mcarare removed the pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land label Dec 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #16915 (ad4e03a) into master (93b13ac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #16915      +/-   ##
============================================
- Coverage     30.78%   30.78%   -0.01%     
  Complexity     1240     1240              
============================================
  Files           455      455              
  Lines         18610    18614       +4     
  Branches       2603     2604       +1     
============================================
  Hits           5730     5730              
- Misses        12421    12425       +4     
  Partials        459      459
Impacted Files Coverage Δ Complexity Δ
...java/org/mozilla/fenix/components/metrics/Event.kt 33.87% <0.00%> (-0.11%) 0.00 <0.00> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt 12.42% <0.00%> (-0.05%) 5.00 <0.00> (ø)
...java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt 10.00% <0.00%> (-0.21%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b13ac...ad4e03a. Read the comment docs.

@mcarare mcarare merged commit 01db516 into mozilla-mobile:master Dec 15, 2020
@eliserichards eliserichards mentioned this pull request Jun 14, 2021
Merged
3 tasks
@mdboom mdboom mentioned this pull request Aug 26, 2021
Merged
3 tasks
@eliserichards eliserichards mentioned this pull request Oct 8, 2021
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boek boek boek approved these changes

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcarare @codecov-io @boek